encode review. Bug Corrections

revpoint / logstash-codec-avro_schema_registry

A logstash codec plugin for decoding and encoding Avro records

Other

26 stars 23 forks source link

encode review. Bug Corrections #9

Closed cgiraldo closed 7 years ago

cgiraldo commented 7 years ago

HI @ryananguiano, finally I have reviewed your encode branch #5. I have found two bugs:

subject_version config parameter should be schema_version.
schema_uri config should be validated as string. If validated as uri, it fails with the default "nil" value.
require base64 to use Base64.

I have also added a binary_encoded config option for the case you want the output to be directly bytes and not Base64 encoded String. (I need that for my use case).

ryananguiano commented 7 years ago

@cgiraldo This looks great! Thanks for the help. I think this should be ready to merge to master and push up to plugins.