revpriest / listman

An email-list manager for NextCloud
GNU General Public License v3.0
18 stars 2 forks source link

import/export Members #15

Open jakobroehrl opened 2 years ago

jakobroehrl commented 2 years ago

I have almost 100 members in mailchimp, it's hard to fill out the dialog for every member

revpriest commented 2 years ago

Yes, that's probably a good plan if I ever find any time.

What sort of thing does Mailchimp export? A csv presumably. Probably best with a file-upload dialog rather than a past-into-box I guess?

No promises any time soon though. Lots going on.

jakobroehrl commented 2 years ago

csv should be fine

vinimoz commented 2 years ago

Hello Guys, i'm finalizing the writing, import csv features. If u are interested.

revpriest commented 2 years ago

Oh, as in you're going to send a patch with code for an import/export feature?

Amazing, thank you. Look forward to seeing it. Cheers.

vinimoz commented 2 years ago

Hello,

    Find the patch file for listman-main.js, as it's the only one i modify. It's very simple modification. To finalize, i just need to understand why the createMember function give me an error. To be honest, last time i've developed was 15years ago, so i'm completely lost hihii ;) . I've no idea what all those new library, nodejs, App.vue etc... :) Even lost, i manage to do some modification, let see.

Cheers.

Vincent

Le 19/12/2021 à 02:34, revpriest a écrit :

Oh, as in you're going to send a patch with code for an import/export feature?

Amazing, thank you. Look forward to seeing it. Cheers.

— Reply to this email directly, view it on GitHub https://github.com/revpriest/listman/issues/15#issuecomment-997384711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7C5TVYAMKWWX6XWR5ZED3URXGMPANCNFSM5GLTCY3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

revpriest commented 2 years ago

Don't see a pull-request, not sure where to look for a patch. If you replied to email to make that comment it'll have stripped off any attachments I think.

Sounds like it's not ready yet anyway though, still an error to fix.

vinimoz commented 2 years ago

It was a patch file created with diff. If u didn't receive it it's mean it's habeen stripped. I just tried to do it with git, 0001-Import-Csv-Feature.patch . I never use git, i've no idea it's the patch has been uploaded or not. Otherwise i don't know how to send u the patch file if attachments are stripped.

Let me know.

Le 20/12/2021 à 06:51, revpriest a écrit :

Don't see a pull-request, not sure where to look for a patch. If you replied to email to make that comment it'll have stripped off any attachments I think.

Sounds like it's not ready yet anyway though, still an error to fix.

— Reply to this email directly, view it on GitHub https://github.com/revpriest/listman/issues/15#issuecomment-998100577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7C5TWNET64UWSJTOH7IMLUR5NKLANCNFSM5GLTCY3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

vinimoz commented 2 years ago

i've fixed my issue, so now import feature working fine. Just wanna add a check mail format function.

Le 20/12/2021 à 06:51, revpriest a écrit :

Don't see a pull-request, not sure where to look for a patch. If you replied to email to make that comment it'll have stripped off any attachments I think.

Sounds like it's not ready yet anyway though, still an error to fix.

— Reply to this email directly, view it on GitHub https://github.com/revpriest/listman/issues/15#issuecomment-998100577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7C5TWNET64UWSJTOH7IMLUR5NKLANCNFSM5GLTCY3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

revpriest commented 2 years ago

Great, thanks.

I believe git-hub's preferred method is to fork the repository, make changes, and then submit a merge request, but can't say I've ever had one so not really sure how to deal with one either.

Only submitted one or two.

Presumably you're running a nextcloud so I suppose hosting a patch there and linking to it would work if that doesn't.

vinimoz commented 2 years ago

So you finally received ? i've follow this procedure https://www.srcmake.com/home/gitpatch to create the patch.

I follow it until "How To Deploy A Git Patch File" as they are talking about the project owner, so you :)

Le 21/12/2021 à 00:22, revpriest a écrit :

Great, thanks.

I believe git-hub's preferred method is to fork the repository, make changes, and then submit a merge request, but can't say I've ever had one so not really sure how to deal with one either.

Only submitted one or two.

Presumably you're running a nextcloud so I suppose hosting a patch there and linking to it would work if that doesn't.

— Reply to this email directly, view it on GitHub https://github.com/revpriest/listman/issues/15#issuecomment-998655105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7C5TTG66VTOO3Z3YNKRTTUSBINDANCNFSM5GLTCY3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

revpriest commented 2 years ago

You'll have ended up with a file.

You can attach files in GitHub by pasting them into the comment.

But you can't attach a file in a reply via email, only in their web interface.

Thanks for it, I look forward to seeing it, but it'll be January now probably before I can look at it in enough detail to include it, so no rush and take the time to be sure you got all the bugs ;)

If you can figure out how to do a fork and pull-request via git-hub I reckon that'll look better on both our CVs. ;)

vinimoz commented 2 years ago

0001-CsvImportMemberFeature.patch.zip

Hello just renamed it 0001-CsvImportMemberFeature.patch let me know if it's working.

revpriest commented 2 years ago

Hey, thanks! Hope you had a good xmas/new-year.

That isn't a zip, so calling it .zip was confusing for a while.

Then dunno why it had a diff on the binary files. Had to skip that.

Then lots of errors like the ones at the bottom here. The Lint in NextCloud is the most frustrating strict thing I've ever come across. Fixed all those anyway.

Grouped the UI with a box in the hope of showing the import and select-file buttons were related.

Otherwise all seems good, have added it and pushed a new version here on GitHub and also to the Nextcloud App Store.

Thank you.

This is just an Import function though, so will leave the ticket open in case anyone ever gets around to making an export too.


  803:8   error    'reader' is never reassigned. Use 'const' instead     prefer-const
  804:8   error    Identifier 'file_name' is not in camel case           camelcase
  804:8   error    'file_name' is never reassigned. Use 'const' instead  prefer-const
  805:8   error    Identifier 'file_size' is not in camel case           camelcase
  805:8   error    'file_size' is assigned a value but never used        no-unused-vars
  805:8   error    'file_size' is never reassigned. Use 'const' instead  prefer-const
  805:17  error    Operator '=' must be spaced                           space-infix-ops
  807:4   error    Unexpected var, use let or const instead              no-var
  807:12  error    Operator '=' must be spaced                           space-infix-ops
  809:17  error    Operator '=' must be spaced                           space-infix-ops
  809:27  error    Unexpected space before function parentheses          space-before-function-paren
  810:1   error    Expected indentation of 4 tabs but found 3            indent
  810:8   error    Identifier 'obj_csv' is not in camel case             camelcase
  810:8   error    'obj_csv' is never reassigned. Use 'const' instead    prefer-const
  811:1   error    Expected indentation of 4 tabs but found 3            indent
  811:4   error    Unexpected var, use let or const instead              no-var
  812:1   error    Expected indentation of 4 tabs but found 3            indent
  812:4   error    Unexpected var, use let or const instead              no-var
  812:8   error    'headers' is assigned a value but never used          no-unused-vars
  813:1   error    Expected indentation of 4 tabs but found 3            indent
  813:4   error    Unexpected var, use let or const instead              no-var
  813:8   error    'lines' is assigned a value but never used            no-unused-vars
  813:18  error    Extra semicolon                                       semi
  815:1   error    Expected indentation of 4 tabs but found 3            indent
  815:4   error    Expected space(s) after "for"                         keyword-spacing
  815:8   error    Unexpected var, use let or const instead              no-var
  815:13  error    Operator '=' must be spaced                           space-infix-ops
  815:18  error    Operator '<' must be spaced                           space-infix-ops
  815:38  error    Operator '-' must be spaced                           space-infix-ops
  816:1   error    Expected indentation of 5 tabs but found 4            indent
  816:5   error    Unexpected var, use let or const instead              no-var
  817:1   error    Expected indentation of 5 tabs but found 4            indent
  818:1   error    Expected indentation of 6 tabs but found 5            indent
  819:1   error    Expected indentation of 6 tabs but found 5            indent
  820:1   error    Expected indentation of 6 tabs but found 5            indent
  821:1   error    Expected indentation of 6 tabs but found 5            indent
  822:1   error    Expected indentation of 6 tabs but found 5            indent
  822:20  warning  Missing trailing comma                                comma-dangle
  823:1   error    Expected indentation of 5 tabs but found 4            indent
  823:7   error    Extra semicolon                                       semi
  824:1   error    Expected indentation of 5 tabs but found 4            indent
  824:17  error    Operator '=' must be spaced                           space-infix-ops
  824:18  error    A space is required after '{'                         object-curly-spacing
  824:22  error    Missing space before value for key 'id'               key-spacing
  824:24  error    A space is required after ','                         comma-spacing
  824:30  error    Missing space before value for key 'name'             key-spacing
  824:37  error    A space is required after ','                         comma-spacing
  824:44  error    Missing space before value for key 'email'            key-spacing
  824:51  error    A space is required after ','                         comma-spacing
  824:60  error    Missing space before value for key 'list_id'          key-spacing
  824:78  error    A space is required after ','                         comma-spacing
  824:85  error    Missing space before value for key 'state'            key-spacing
  824:86  error    A space is required before '}'                        object-curly-spacing
  825:1   error    Expected indentation of 5 tabs but found 4            indent
  828:31  error    Missing space before opening brace                    space-before-blocks
  828:59  error    Identifier 'file_name' is not in camel case           camelcase
  828:69  error    Extra semicolon                                       semi
  828:72  error    Extra semicolon        
vinimoz commented 2 years ago

Hi, Wish you as well happy new year/xmas. It's look it's more indent issue, it's true i didn't do indent of the files before send it.

Perfect,  u leave open the ticket, as i would like to add as well the possibility to import NC users into the mailing list. But first i need to understand how to perform ajax request in NC ;)

Thank you

Le 05/01/2022 à 10:29, revpriest a écrit :

Hey, thanks! Hope you had a good xmas/new-year.

That isn't a zip, so calling it .zip was confusing for a while.

Then dunno why it had a diff on the binary files. Had to skip that.

Then lots of errors like the ones at the bottom here. The Lint in NextCloud is the most frustrating strict thing I've ever come across. Fixed all those anyway.

Grouped the UI with a box in the hope of showing the import and select-file buttons were related.

Otherwise all seems good, have added it and pushed a new version here on GitHub and also to the Nextcloud App Store.

Thank you.

This is just an Import function though, so will leave the ticket open in case anyone ever gets around to making an export too.

|803:8 error 'reader' is never reassigned. Use 'const' instead prefer-const 804:8 error Identifier 'file_name' is not in camel case camelcase 804:8 error 'file_name' is never reassigned. Use 'const' instead prefer-const 805:8 error Identifier 'file_size' is not in camel case camelcase 805:8 error 'file_size' is assigned a value but never used no-unused-vars 805:8 error 'file_size' is never reassigned. Use 'const' instead prefer-const 805:17 error Operator '=' must be spaced space-infix-ops 807:4 error Unexpected var, use let or const instead no-var 807:12 error Operator '=' must be spaced space-infix-ops 809:17 error Operator '=' must be spaced space-infix-ops 809:27 error Unexpected space before function parentheses space-before-function-paren 810:1 error Expected indentation of 4 tabs but found 3 indent 810:8 error Identifier 'obj_csv' is not in camel case camelcase 810:8 error 'obj_csv' is never reassigned. Use 'const' instead prefer-const 811:1 error Expected indentation of 4 tabs but found 3 indent 811:4 error Unexpected var, use let or const instead no-var 812:1 error Expected indentation of 4 tabs but found 3 indent 812:4 error Unexpected var, use let or const instead no-var 812:8 error 'headers' is assigned a value but never used no-unused-vars 813:1 error Expected indentation of 4 tabs but found 3 indent 813:4 error Unexpected var, use let or const instead no-var 813:8 error 'lines' is assigned a value but never used no-unused-vars 813:18 error Extra semicolon semi 815:1 error Expected indentation of 4 tabs but found 3 indent 815:4 error Expected space(s) after "for" keyword-spacing 815:8 error Unexpected var, use let or const instead no-var 815:13 error Operator '=' must be spaced space-infix-ops 815:18 error Operator '<' must be spaced space-infix-ops 815:38 error Operator '-' must be spaced space-infix-ops 816:1 error Expected indentation of 5 tabs but found 4 indent 816:5 error Unexpected var, use let or const instead no-var 817:1 error Expected indentation of 5 tabs but found 4 indent 818:1 error Expected indentation of 6 tabs but found 5 indent 819:1 error Expected indentation of 6 tabs but found 5 indent 820:1 error Expected indentation of 6 tabs but found 5 indent 821:1 error Expected indentation of 6 tabs but found 5 indent 822:1 error Expected indentation of 6 tabs but found 5 indent 822:20 warning Missing trailing comma comma-dangle 823:1 error Expected indentation of 5 tabs but found 4 indent 823:7 error Extra semicolon semi 824:1 error Expected indentation of 5 tabs but found 4 indent 824:17 error Operator '=' must be spaced space-infix-ops 824:18 error A space is required after '{' object-curly-spacing 824:22 error Missing space before value for key 'id' key-spacing 824:24 error A space is required after ',' comma-spacing 824:30 error Missing space before value for key 'name' key-spacing 824:37 error A space is required after ',' comma-spacing 824:44 error Missing space before value for key 'email' key-spacing 824:51 error A space is required after ',' comma-spacing 824:60 error Missing space before value for key 'list_id' key-spacing 824:78 error A space is required after ',' comma-spacing 824:85 error Missing space before value for key 'state' key-spacing 824:86 error A space is required before '}' object-curly-spacing 825:1 error Expected indentation of 5 tabs but found 4 indent 828:31 error Missing space before opening brace space-before-blocks 828:59 error Identifier 'file_name' is not in camel case camelcase 828:69 error Extra semicolon semi 828:72 error Extra semicolon |

— Reply to this email directly, view it on GitHub https://github.com/revpriest/listman/issues/15#issuecomment-1006054772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7C5TQZJHLWMDKRH2WXQR3UUSS4DANCNFSM5GLTCY3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>