search

revsys / django-test-plus

Useful additions to Django's default TestCase
https://django-test-plus.readthedocs.io
BSD 3-Clause "New" or "Revised" License
612 stars 62 forks source link

Use pytest's native python path support #211

Closed offbyone closed 5 months ago

offbyone commented 5 months ago

This is added in Pytest 7

Fixes my failure to locally CI as mentioned in https://github.com/revsys/django-test-plus/pull/210#issuecomment-2081532869

offbyone commented 5 months ago

@fcurella would you be in a position to merge this? With this in, #210 will work, and with #210 in, I can upgrade to 3.12 :D

fcurella commented 5 months ago

I can merge this, but I will consider it a breaking change and I'd like to give it some more visibility.

cc @frankwiles @jefftriplett

jefftriplett commented 5 months ago

I'll ping @frankwiles and ask him today. In theory, bumping to a major version and dropping the dependency feels like the right thing to do. If this breaks for someone, then we can pin to the previous version since it's been stable for years.

offbyone commented 5 months ago

Fair! I think in my head I considered Pytest to be a "test dependency" but... so is this one, so they're sharing a dependency closure :D

It's obvious in hindsight.

jefftriplett commented 5 months ago

I'm merging these to get ready for a release. We hope to get them both in tomorrow, but the repo might be a little off for a bit.