search

revsys / django-tos

A small app to ensure your users re-agree to Terms of Service changes
BSD 3-Clause "New" or "Revised" License
153 stars 42 forks source link

django3.0 support #45

Closed hhummel closed 3 years ago

hhummel commented 3 years ago

django.shortcuts.render_to_response was deprecrated jn django3.0 so lhat line 11 in views.py throws an error. Any plans to support v3.0?

nicholasserra commented 3 years ago

Yup shouldn't be a big deal. Can easily wire it into compat.py. PRs welcome, otherwise i'll add this to my queue and knock it out eventually.

hhummel commented 3 years ago

I took a crack at it. Thanks for the quick response! Apologies for the 500 random files in the PR.

hhummel commented 3 years ago

Better have django 3 in Travis! Took a shot at that too. Sorry about all the noise

NathanSmeltzer commented 2 years ago

@nicholasserra can the Pypi package be updated to include this change? I ran pip install django-tos and it's an older commit where views.py imports render_to_response and it throws an error in Django 3 For now, I'll try installing from this specific commit. Thanks for all your work! And thanks @hhummel for the Django 3 compatibility update.

nicholasserra commented 2 years ago

@frankwiles can we get a new version and pypi release for this django compat? Thanks!

cc @occamssafetyrazor