search

revsystems / jQuery-SelectBox

A modern replacement for the traditional select element. Increases flexibility and stylability.
http://plugins.jquery.com/project/jquery-sb
Other
72 stars 16 forks source link

Fixes mouseup and ensure unbinding of keystroke events #23

Closed tvdeyen closed 13 years ago

tvdeyen commented 13 years ago

Converted all mousdown events to mouseup events. Ensuring that the keystroke event observers are getting unbinded if closing the selectbox (especially while cloking outside of the selectbox)

tvdeyen commented 13 years ago

Hmm, any luck with merging these pull request via github? I just saw that the old pullrequest is still open?

MaxPower15 commented 13 years ago

Yeah, I should probably just close the old one. I manually merged in the changes for that a while ago.

tvdeyen commented 13 years ago

I made some more fixes. Just close this and I send a new one for these fixes. That should work, I hope.

MaxPower15 commented 13 years ago

Also, I'm not certain the mousedown events should be moved to mouseup events? I know this is generally how it is for buttons and the like, but my tests on the original <select> element opened on mousedown. Practically speaking, I do think it feels a little more responsive on mousedown. But I don't know if I like it.

Need to think for a day or two on this...

tvdeyen commented 13 years ago

Hmm, you are on windows? I am on a Mac and my selects all opening on mouseup, like all other buttons and gui elements in the whole operation system. This is very handy. Think of accidentally pressed buttons. With mouseup events you could move the mouse outside the element while holding down the button and after releasing the event does not fire on this element any more! Very nice ;)

tvdeyen commented 13 years ago

Could you please reopen the ticket? I accidentally hit comment and close ;)

revsystems commented 13 years ago

Yeah, I'm doing my tests on windows. I think you're right about this; I should definitely be taking UX cues from macs instead of windows.

I will try merging this soon, but it may be a few days. Busy with a few other projects at the moment. Really appreciate your contributions. Thanks

tvdeyen commented 13 years ago

You are always welcome. Glad to be a help with your wonderful plugin.