search

revtel / react-native-nfc-manager

React Native NFC module for Android & iOS
MIT License
1.35k stars 317 forks source link

Update to latest @expo/config-plugins #631

Closed dylanclements closed 1 year ago

dylanclements commented 1 year ago

npx expo-doctor indicates invalid @expo/config-plugins@4.1.5:

[stderr] 
Expected package @expo/config-plugins@~6.0.0
[stderr] 
  Found invalid:
[stderr] 
    @expo/config-plugins@4.1.5
[stderr] 
    (for more info, run: npm why @expo/config-plugins)

Which can be traced back to react-native-nfc-manager:

@expo/config-plugins@4.1.5
node_modules/react-native-nfc-manager/node_modules/@expo/config-plugins
  @expo/config-plugins@"^4.0.16" from react-native-nfc-manager@3.14.2
  node_modules/react-native-nfc-manager
    react-native-nfc-manager@"^3.14.2" from the root project

Updating to @expo/config-plugins": "^6.0.1 should mean this no longer appears.

Diffed outputs from npx expo config --type prebuild and confirmed that there is no change in output.

If this change is too pedantic/inconsequential to adopt, please close this PR :)

whitedogg13 commented 1 year ago

@dylanclements thanks for the contribution!