search

rewardenv / reward

Reward is a Swiss Army knife CLI utility for orchestrating Docker based development environments.
https://rewardenv.readthedocs.io
MIT License
90 stars 13 forks source link

Establishing order on the EditorConfig front #42

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

Currently the repository deviates from EditorConfig settings. (checked with eclint)

Would you welcome global 4-space indenting?

🍇 Much better readability 🍇

szepeviktor commented 1 year ago

I'm new to the Go ecosystem.

Again, in Golang, Use spaces only if you must. Tabs for indentation is the official recommendation.

They want the typewriter back 🙃

image

Then TAB characters for Go source code and 4-space indentation for the rest.

janosmiko commented 1 year ago

It's already there but configured to use 2 spaces globally. This repo contains a bunch of yaml template files so I'd prefer to keep it as is. https://github.com/rewardenv/reward/blob/main/.editorconfig

szepeviktor commented 1 year ago

I usually say: it is like wind-blown text, hard to distinguish indentations. Although 2-space indentation is very highly popular.