rewardz / Feeds

Feeds
Other
2 stars 1 forks source link

Feat/mario/correct import in setup #8

Closed axoloteDeAccion closed 4 years ago

axoloteDeAccion commented 4 years ago

Had to make some corrections to allow Flabuless to be installed from scratch, rather than in an already existing environment (Like a docker image I use for development).

First corrected the "import rewardz_user_importer as app" for "import feeds as app", this was causing the error I mentioned to Piklu on Skype, as this package doesn't have a rewardz_user_importer package and would error out when deploying a new server. Also this causes the feeds package to have whatever version of the already installed rewardz_user_importer, so "feeds" in flabuless was version 1.13, while on Cerra I believe it's version 1.32. This is gonna cause update problems on places where this package has already been deployed. I left the bumped version as "0.0.8" while correcting the import, but I suggest bumping all the way to 2.0.0 to avoid this. But leave it to you guys to make this call as I don't know where this package has already been deployed.

Then I corrected some dependencies that were also causing conflict with Flabuless versions. These dependencies don't seem to be doing anything in particular from a cursory look on the package, so I'm guessing this won't be an issue.

Then I removed other dependencies, like strava and runkeeper, as they were conflicting and also seems that they are not used for the package.

I'm changing the flabuless requirements.txt to point to my fork of the package for now, otherwise installs from scratch get borked and this would be scary in prod.