search

rewdy / Pico-Pagination

Provides basic pagination for Pico.
27 stars 12 forks source link

added filter for sub_page #21 #22

Open ghost opened 3 years ago

ghost commented 3 years ago

Added filter when pagination_sub_page setting is true. So pagination is done only for items located in the sub folder with same name like pagination_page_indicator setting.

rewdy commented 3 years ago

Will review tomorrow and merge.

rewdy commented 3 years ago

@RandomRouter Hey, I think this is good, but do you think there would be any value to making this more configurable?

I'm thinking maybe adding config like pagination_directory that would, set a subfolder to look at for pagination that an implementation could match to their sub_page name (close to what you have here) or it could be separate?

I'm open to feedback on this. Just not wanting to break anything folks already have implemented.

ghost commented 3 years ago

pagination_directory sounds more generic which I think is good. Maybe you can add this as an option and keep the current behavior as the default.

digitalinferno commented 2 years ago

I have tested the patch and it works fine as expected.