rewe-digital / composer

Dynamically composes markup generated by microservices. Based on Java8, reactive patterns and Spotify Apollo. Made with 💙 in cologne.
Apache License 2.0
10 stars 2 forks source link

implemented limit for recursive includes #12

Closed thovid closed 6 years ago

thovid commented 6 years ago

Resolves #10

codecov[bot] commented 6 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.86%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     80.83%   81.69%   +0.86%     
- Complexity      270      285      +15     
============================================
  Files            34       36       +2     
  Lines           720      754      +34     
  Branches         35       36       +1     
============================================
+ Hits            582      616      +34     
  Misses          114      114              
  Partials         24       24
Impacted Files Coverage Δ Complexity Δ
...om/rewedigital/composer/composing/Composition.java 97.05% <ø> (ø) 11 <0> (ø) :arrow_down:
...l/composer/configuration/DefaultConfiguration.java 93.75% <100%> (+0.41%) 4 <0> (ø) :arrow_down:
...ewedigital/composer/composing/CompositionStep.java 100% <100%> (ø) 7 <7> (?)
.../composer/composing/ComposerHtmlConfiguration.java 100% <100%> (ø) 7 <4> (+2) :arrow_up:
...ewedigital/composer/composing/IncludedService.java 100% <100%> (ø) 11 <3> (+2) :arrow_up:
...al/composer/composing/AttoParserBasedComposer.java 100% <100%> (ø) 9 <0> (ø) :arrow_down:
...gital/composer/composing/IncludeMarkupHandler.java 70.88% <100%> (ø) 21 <0> (ø) :arrow_down:
...l/composer/composing/ValidatingContentFetcher.java 95% <100%> (ø) 9 <0> (ø) :arrow_down:
...om/rewedigital/composer/routing/TemplateRoute.java 95.45% <100%> (+0.21%) 11 <1> (ø) :arrow_down:
...wedigital/composer/composing/IncludeProcessor.java 100% <100%> (ø) 8 <3> (ø) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9c4fcc...1544311. Read the comment docs.

AndreasKl commented 6 years ago

Squashed and merged.