search

rewe-digital / composer

Dynamically composes markup generated by microservices. Based on Java8, reactive patterns and Spotify Apollo. Made with 💙 in cologne.
Apache License 2.0
10 stars 2 forks source link

Add the facility to override the request timeout per include and route. #28

Closed AndreasKl closed 6 years ago

AndreasKl commented 6 years ago

Todo: Add E2E test.

thovid commented 6 years ago

Thanks for the rework! Added issue #29 for the discussion about null vs optional and #30 for the discussion about timeout vs ttl. I'm merging the PR even though the end-2-end test is missing. I'm not sure if we should add one for something like request timeouts (ugly to test anyways ;-) ).

thovid commented 6 years ago

Ah darn, right after merging this: Could you update the readme.md to document the new features?