Closed rewin123 closed 7 months ago
Attention: Patch coverage is 13.58025%
with 140 lines
in your changes are missing coverage. Please review.
Project coverage is 34.57%. Comparing base (
96e8551
) to head (353b413
). Report is 3 commits behind head on v0.6.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test without features CI failed with this error, weird.....
Test without features CI failed with this error, weird.....
Might be a linker problem on CI. Maybe we could run CI on windows or be sure to have it correctly setup for linux https://github.com/bevyengine/bevy/blob/main/docs/linux_dependencies.md
But I see this is passing now
I would always recommend adding UI screenshots when changing stuff that touch the UI, besides that, this is a pretty good change and clearly documented. Nice work
Might be a linker problem on CI. Maybe we could run CI on windows or be sure to have it correctly setup for linux https://github.com/bevyengine/bevy/blob/main/docs/linux_dependencies.md
Sometimes space_editor folder fills 20-30 gb of my disk space for debug target. So, I switched to release mode to try to fix this
I would always recommend adding UI screenshots when changing stuff that touch the UI, besides that, this is a pretty good change and clearly documented. Nice work
UI shouldn't have changed, just the api
Part of #267
This PR allows you to:
Major changes:
/// Push tabs to group of layout app.layoutpush::<DoublePanelGroup, , _>(DoublePanel::MainPanel, EditorTabName::GameView); app.layoutpush::<DoublePanelGroup, , _>(DoublePanel::TopPanel, EditorTabName::Hierarchy); app.layoutpush::<DoublePanelGroup, , _>( DoublePanel::BottomPanel, EditorTabName::Inspector, );
/// We can push showed tab on front of list if we want app.layout_pushfront::<DoublePanelGroup, , _>( DoublePanel::MainPanel, EditorTabName::Resource, );
Next steps in next PRs: