rewin123 / space_editor

bevy prefab editor
MIT License
386 stars 49 forks source link

Fix camera vewport bug #304

Closed rewin123 closed 6 months ago

rewin123 commented 6 months ago

298

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 37.76%. Comparing base (8586378) to head (03d7635).

Files Patch % Lines
crates/editor_ui/src/game_view.rs 0.00% 21 Missing :warning:
crates/editor_ui/src/settings.rs 0.00% 15 Missing :warning:
crates/editor_core/src/lib.rs 0.00% 1 Missing :warning:
crates/editor_ui/src/lib.rs 0.00% 1 Missing :warning:
crates/editor_ui/src/menu_toolbars.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #304 +/- ## ========================================== - Coverage 37.82% 37.76% -0.07% ========================================== Files 58 58 Lines 9514 9530 +16 ========================================== Hits 3599 3599 - Misses 5915 5931 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

naomijub commented 6 months ago

Lint and fmt failed, I think this can be tested, seems like a simple test implementation

naomijub commented 6 months ago

To have the lint fixed you should have rust latest, as the CI. Rustup update

rewin123 commented 6 months ago

To have the lint fixed you should have rust latest, as the CI. Rustup update

Yes, sure. I'm just hoping to wait for verification from whoever noticed the bug in the first place. As soon as I get confirmation that the bug has been fixed there too, I’ll fix clippy and upload it

naomijub commented 6 months ago

Works on my side (improved the macos experience as well). Don't forget to add documentation on git lfs:

### Dependencies
 - Git LFS for assets

git lfs install
git lfs pull