Declaring v1.0.0 - Githubissues

reworkcss / rework-npm

Import CSS from npm modules using rework

BSD 2-Clause "Simplified" License

87 stars 19 forks source link

Declaring v1.0.0 #8

Closed bclinkinbeard closed 10 years ago

bclinkinbeard commented 10 years ago

So, this is kind of becoming a personal mission of mine, but what would you think about declaring a v1? The traditional criteria (stated if not practiced) has been if it's being used in production it's v1+. Coupled with npm's new ^ behavior, it would be great to be able to specify "rework-npm": "^1.0.0" and know any new, non-breaking hotness would be fetched on future installs.

Thoughts?

ben-ng commented 10 years ago

techwraith commented 10 years ago

:+1:

conradz commented 10 years ago

Definitely should do this, but I think we need to wait for the css-parse to release v2.0.0, since the current version breaks with css-parse master.

bclinkinbeard commented 10 years ago

Ah OK, cool. Will that cause the API of rework-npm to change?

conradz commented 10 years ago

Not sure yet, although it could be possible.

conradz commented 10 years ago

Should also get #10 taken care of before a 1.0.

conradz commented 10 years ago

OK, after moving to the reworkcss org and some breaking changes, I think this is ready to go.

Major changes:

Dropped the dir option, always use directory from position.source in the AST (see #10)
Search the alias option for aliased directories when importing (see #15)
Never apply the alias config for relative imports (e.g. @import "./file";)

Please test and provide feedback! /cc @bclinkinbeard @necolas

necolas commented 10 years ago

Looks good to me! A couple of quick tests behaved as I expected.

conradz commented 10 years ago

Released v1.0.0!