search

reworkhow / JWAS.jl

Julia for Whole-genome Analysis Software
http://QTL.rocks
GNU General Public License v2.0
96 stars 44 forks source link

Suggestions #101

Open mdkeehan opened 2 years ago

mdkeehan commented 2 years ago

I tried to track down why the Unit Tests for XSim were failing and ended up looking quite closely at some parts of JWAS on the way. I have made a few suggestions which I have included as a pull request. The only testing I have done is the JWAS unit tests and running under Julia 1.6.3.

  1. The worst error was that mme.Lhs eventually became a Sparsevector of {Any} which does not have an associated zero() function.
  2. A deprecation warning was fixed
  3. genotypes were simplified to be read as Float32 to which they were eventually converted.
reworkhow commented 2 years ago

Hi Mike, this is great! I will look into your pull request and merge it this week.

mdkeehan commented 2 years ago

Hi Hao,

I have thought about this some more. The third commit 78c5faf013aff27c089bf78daa4cd726bbe4e589 is a large style change and interacts with commit da6d2ee. Parts of 78c5faf may be redundant once da6d2ee has gone in. Happy to see what you think and I hope they are useful!

Mike