rex706 / SAM

Steam Account Manager / Switcher
358 stars 45 forks source link

allow users to switch between login prompt versions #157

Closed KillaBoi closed 2 years ago

KillaBoi commented 2 years ago

Valve has fixed command line options in the latest stable release of the Steam Client.

This PR allows the user to switch between the React based Steam Login UI Prompt (therefore allowing the user to easily login without having to enter a Steam Guard code by "approving" the login) or to alternatively switch back to the old non React based login prompt by the usage of a parameter checkbox.

KillaBoi commented 2 years ago

this actually breaks automated sign-in via the automatic input of the shared secret steam guard codes for the new react UI, we will need to look into that...

PindaPixel commented 2 years ago

this actually breaks automated sign-in via the automatic input of the shared secret steam guard codes for the new react UI, we will need to look into that...

Patch note from November 17th:

Fixed an input focus bug requiring an initial click on the sign in UI before you could type your username or password

This the fix you needed?

KillaBoi commented 2 years ago

this actually breaks automated sign-in via the automatic input of the shared secret steam guard codes for the new react UI, we will need to look into that...

Patch note from November 17th:

Fixed an input focus bug requiring an initial click on the sign in UI before you could type your username or password

This the fix you needed?

Could very well be tbh, I will test later today and see whether this is a fix...

KillaBoi commented 2 years ago

just tested, can confirm that patch note does indeed fix the input bug we had.

@rex706, can we accept the PR whenever possible and go ahead and push/make it global? :)

KillaBoi commented 2 years ago

it seems that it is still somehow broken, not sure how or why but after the update something broke with the input where it will either accept it or not accept it

rex706 commented 2 years ago

Unfortunately, there was more work required to get the new UI working while also preserving the old functionality as well that I implemented, so I'm closing this request.

I very much appreciate your help with getting this moving quickly.