search

rexcardan / Evil-DICOM

A C# DICOM Library
170 stars 98 forks source link

Convert to .NET Standard project #58

Closed tirth closed 5 years ago

tirth commented 6 years ago

Hi Rex, it's Tirth from PMH. I mentioned to you at AAPM about updating to the new VS project system - here's the initial port for you to review. There are still a few questions to address, as well as making sure the tests run.

Specifically:

feliwir commented 5 years ago

Can this be merged please?

tirth commented 5 years ago

Just updated the project system a little more by refactoring the code generator, targeting netstandard2.0, and moving it into the main solution, and updated the generated classes using the most recent standard.

feliwir commented 5 years ago

Awesome, great work

feliwir commented 5 years ago

@tirth i am not sure if the owner of this project is still active. Do you have a fork or something?

tirth commented 5 years ago

@feliwir unfortunately I don't have the time to maintain anything official on NuGet, but you can build from my GitHub fork

dalingrin commented 5 years ago

I'd suggest adding net45 to the in the csproj. Many of the computers our software runs on only has .Net Framework 4.5.x. By targetting both net45 and netstandard20, the library will remain compatible with all systems it was prior to this pull request while still getting all the cross-platform benefits of .net standard 2.0.

feliwir commented 5 years ago

@dalingri I don’t think that’s required. .NETStandard can be used by recent .NETFrameworks. NET Framework 4.5. E.g. it works on both Windows 7 & Windows 10 without any issues.

tirth commented 5 years ago

@feliwir It looks like .NET Framework 4.5.* only supports up to .NET Standard 1.2.

@dalingrin I'll look into multitargeting it with netstandard1.2 or net45, I've (fortunately) been stuck with .NET Framework 4.6.1 so netstandard2.0 worked.

@rexcardan Will you have a chance to look over the PR any time soon? I've been adding some more functionality in our fork like a DICOMWeb client and IOD module writing helpers, and experimenting with Span-based reading for more throughput. It builds on the updated project layout here though so I can't quite submit the changes separately.

rexcardan commented 5 years ago

I have created a .net core release in 2.0.5.1