rexcardan / Evil-DICOM

A C# DICOM Library
168 stars 98 forks source link

fileMetaData.ImplementationVersionName #76

Closed xela-trawets closed 4 years ago

xela-trawets commented 4 years ago

FileMetaData.ImplementationVersionName is a UID in the repo My reading of the standard has the ImplementationVersionName as Short String

http://dicom.nema.org/medical/dicom/current/output/chtml/part06/chapter_7.html says (0002,0013) | Implementation Version Name | Implementation​Version​Name | SH | 1

perhaps I am using this the wrong way ?

ps. I am writing digital image files for NDT (diconde).

xela-trawets commented 4 years ago

For those who find their way here: dcm.Remove(TagHelper.ImplementationVersionName); var ImplementationVersionNameTag = new ShortString(); ImplementationVersionNameTag.Tag = new Tag(TagHelper.ImplementationVersionName.CompleteID); ImplementationVersionNameTag.DData = "ALEX!"; dcm.Add(ImplementationVersionNameTag);

I ought to add that I spent the last few days trying various Dicom projects (Fellow Oak dicom, Offis, other code (Dave Clunie's site)), specifically to learn how to handle Dicom FileIO and that Evil-Dicom is easily my favourite. It has just the right blend of detail and simplicity for me, (and can extract tags from files that make other systems barf).

xela-trawets commented 4 years ago

Closing this, looks fine now

xela-trawets commented 4 years ago

Tried to make a PR with this, but the diff ended up being huge... line 108 in FileMetaData.cs

--- private readonly UniqueIdentifier _implementationVersionName = new UniqueIdentifier +++ private readonly ShortString _implementationVersionName = new ShortString

A