search

rexdex / recompiler

Xbox360 -> Windows executable converter
MIT License
1.64k stars 81 forks source link

Fix arg parsing bug; minor changes to project files #24

Closed sumit0190 closed 6 years ago

sumit0190 commented 6 years ago

Ignore the changes to the .vcxproj files - I changed a linker option to reduce warnings during build time.

The actual change is in the code for parsing command line arguments (issue #23), which is weirdly in internalUtils.cpp, a part of the Commandline class. Confusingly enough, this class is also defined in launcherCommandline.cpp, but it looks like in this particular case that implementation is not being used. Along with that fix, I deleted unused constructors and methods for that class as well, but I can revert those changes if you think you are going to need them later.

rexdex commented 6 years ago

Nice refactor. It's shitty that I copied the commandline parser in two places but I try not to have any direct coupling between the runtime and the recompiler part.