search

rexim / org-cliplink

Insert org-mode links from clipboard
323 stars 11 forks source link

ignore case when searching for title tag #103

Closed d12frosted closed 6 years ago

d12frosted commented 6 years ago

fixes #101

Let me know if you have any comments or suggestions.

rexim commented 6 years ago

@d12frosted did you know that t is the default value of case-fold-search? https://www.gnu.org/software/emacs/manual/html_node/elisp/Searching-and-Case.html

This buffer-local variable determines whether searches should ignore case. If the variable is nil they do not ignore case; otherwise (and by default) they do ignore case.

Yeah, me neither. Otherwise I wouldn't create #101. :)

But I guess we still need these changes because

  1. It's better to not rely on a default value (it's unlikely that Emacs devs will change it in the future, but still)
  2. We don't have a test case for capitilzed titles.

So, LGTM :+1:

Thank you very much for the Pull Request!

d12frosted commented 6 years ago

Hey @rexim

Yeah, I did know that the default value is t, but I know a person or two who set it to nil in their configs. And I think that this library should not take be broken by such configurations :)