search

rexrainbow / phaser3-rex-notes

Notes of phaser3 engine
MIT License
1.2k stars 260 forks source link

Invalid TS type for ColorPicker configs #339

Closed jqpoon closed 1 year ago

jqpoon commented 1 year ago

Hello,

valuechangeCallbackScope is a valid config for ColorPicker according to https://rexrainbow.github.io/phaser3-rex-notes/docs/site/ui-colorpicker/. It works if typechecking is disabled.

However, it seems like the typescript definitions at https://github.com/rexrainbow/phaser3-rex-notes/blob/master/templates/ui/colorinput/colorpicker/ColorPicker.d.ts are not updated.

Thanks!

rexrainbow commented 1 year ago

Added, thanks for this reporting.