rexstout / abcde

Automatically exported from code.google.com/p/abcde
GNU General Public License v2.0
0 stars 0 forks source link

sometimes flac fails with "floating point exception" #113

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Insert CD with problematic track (for instance "De Kift - Biddonville")
2. Run: abcde -o flac 16
3. See it fail

What is the expected output? What do you see instead?

The track was extracted to wav (by cdparanoia) but not encoded to flac.  Abcde 
seems to wait for the flac file to appear forever.  On stderr you'll see:

  /usr/bin/abcde: line 249: 6437 Floating point exception(core dumped) "$@" 1>&2

What version of the product are you using? On what operating system?

abcde 2.5.4-6, cdparanoia 10.2-5 and flac 1.3.0-3 on Arch Linux 

Please provide any additional information below.

There is a workaround for this (source: ubuntu launchpad#1219087). By adding 
the "--silent" flag to FLACOPTS the problem is avoided. The "solution" seems 
fine since abcde discards the flac encoding output anyway.

Original issue reported on code.google.com by rwvtv...@gmail.com on 26 Sep 2014 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago
There seems to be a choice there:

andrew@ilium~$ flac -h | grep silent
  -s, --silent                 Do not write runtime encode/decode statistics
      --totally-silent         Do not print anything, including errors
      --no-silent

Which seems a little odd as you would expect --silent to still produce this 
error, according to the flac help file. 

Are you running the latest flac? This is:

andrew@ilium~$ flac --version
flac 1.3.1

Original comment by andrew.d...@gmail.com on 5 Jan 2015 at 7:36

GoogleCodeExporter commented 9 years ago
The error is in flac; when the console width can not be determined for 
rendering a progressbar it divides by zero.  The -s switch avoids the problem.

However, the problem is solved in flac 1.3.1;

  https://git.xiph.org/?p=flac.git;a=commit;h=9443151da38d25430f0683dfdcd7f6076ecabe0a

Sorry about not reporting this.

Original comment by rwvtv...@gmail.com on 5 Jan 2015 at 8:07

GoogleCodeExporter commented 9 years ago
Thanks for the link. I will add the option in as soon as my git access is 
rectified. Thought about some version sniffing but I will simply leave a note 
against the change I suspect, not that many will be using flac 1.3.1 in the 
near future...

Original comment by andrew.d...@gmail.com on 6 Jan 2015 at 7:02

GoogleCodeExporter commented 9 years ago

Original comment by andrew.d...@gmail.com on 6 Jan 2015 at 7:13

GoogleCodeExporter commented 9 years ago
Thanks for the report and the workaraound which have been implemented in 
current git. 

Thanks again,

Andrew

Original comment by andrew.d...@gmail.com on 10 Jan 2015 at 8:49