PATCH: eyeD3 version switch < 0.7 vs. >= 0.7

[GoogleCodeExporter]

The attached PATCH implements an eyeD3 version switch. 

It makes abcde default to 0.7+ syntax, but if the eyeD3 executable can be run 
and offers a --set-encoding through --help, patched abcde switches to the older 
syntax (--set-encoding utf16-LE as default argument, to give one example).

Note that maintainers may want to look into Issue #101 as well which is about
character encoding and ID3 tag versions.

Original issue reported on code.google.com by matthias...@gmx.de on 20 Oct 2014 at 10:27

Attachments:

• abcde-eyeD3-version-switch.patch

[GoogleCodeExporter]

It looks good, I will hopefully be able to add this in the New Year when Steve 
adds me back into the loop. I also note that the old and new versions share one 
common element with the 'COMMENT' tag: both share:

-c COMMENT

which would be good to change from the current setup as well. I attach help 
output for 0.6.14 and 0.7.5 in case wiser eyes than mine can spot any other 
problems :). I hope there have not been small but significant changes in the 
syntax in between!

Original comment by andrew.d...@gmail.com on 28 Dec 2014 at 7:24

Attachments:

• eyeD3_0.6.14
• eyeD3_0.7.5

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I have had a little time and adding in the comment tag was easy enough. I add 
the slightly emended patch to this post. Works nicely here when alternating 
between 0.6.4 and 0.7.5.

I have made the patch on the git version + some of my own un-pushed revisions 
so my apologies that the line numbers are out a little but the meaning is 
obvious.

Just waiting for push access to be fixed up....

Original comment by andrew.d...@gmail.com on 3 Jan 2015 at 10:12

• Changed state: Accepted
• Added labels: Usability

Attachments:

• abcde-eyeD3-version-switch_2.patch

[GoogleCodeExporter]

Thanks for this patch Matthias which I have pushed to git (with the minor 
addition of the --comment syntax changes):

git commit 956fc01de954b172faa6b726d46934500f75742f

Please test this out and suggest any further work that needs to be done.

Original comment by andrew.d...@gmail.com on 8 Jan 2015 at 8:36

• Changed state: Fixed