rexstout / abcde

Automatically exported from code.google.com/p/abcde
GNU General Public License v2.0
0 stars 0 forks source link

Support for OGG Opus #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Opus is a new audio codec which provides very high quality and is currently 
about to become a standard by the IETF.
http://www.opus-codec.org/

It would be very nice to have support in abcde, as it has very high quality 
with decent filesizes.

Original issue reported on code.google.com by hanno@hboeck.de on 5 Jul 2012 at 10:21

GoogleCodeExporter commented 9 years ago
Now it is standard: http://tools.ietf.org/html/rfc6716 

Original comment by tomasz.g...@gmail.com on 12 Sep 2012 at 10:37

GoogleCodeExporter commented 9 years ago
Patches welcome :-)

Original comment by EinvalSl...@googlemail.com on 26 Sep 2012 at 4:22

GoogleCodeExporter commented 9 years ago
It is really ugly job, but I prepared something which seems to work for me. 
Unfortunately, afaik opus-tools don't come with separate tagger yet, so tagging 
is done at the same time as encoding. Hope it all makes at least a bit of sense 
;)

Original comment by tomasz.g...@gmail.com on 9 Oct 2012 at 11:09

Attachments:

GoogleCodeExporter commented 9 years ago
Thomasz, thanks for your work.

Regarding a separate tagger: You can just use the same as for ogg vorbis. The 
".opus"-fileformat is not a fileformat by itself, it's just an ogg container 
file that embedds an opus audio stream.

Original comment by hanno@hboeck.de on 10 Oct 2012 at 10:31

GoogleCodeExporter commented 9 years ago
I know that in principle it should, but vorbiscomment was returning error. It 
was getting late, so I adopted speex tagging code. I'll try to play with 
vorbiscomment a bit more and see if it is possible to make it better.

Original comment by tomasz.g...@gmail.com on 10 Oct 2012 at 11:19

GoogleCodeExporter commented 9 years ago
It isn't that simple unfortunately. Tags seem to reside inside Opus stream, and 
ogginfo is not picking them up:

New logical stream (#1, serial: 40ab472b): type unknown
Logical stream 1 ended

Any attempt to read or write the tags with vorbiscomment only produces this 
error:
Failed to open file as Vorbis: Ogg bitstream does not contain a supported 
data-type.

Unless I'm missing something, we would have to wait for update to vorbis-tools 
or opus-tools (or try something different, like mutagen, but that would be 
nasty).

Original comment by tomasz.g...@gmail.com on 10 Oct 2012 at 11:14

GoogleCodeExporter commented 9 years ago
An interesting note at the top of the speex page:

—The Speex codec has been obsoleted by Opus. It will continue to be 
available, but since Opus is better than Speex in all aspects, users are 
encouraged to switch— 

http://www.speex.org/

Original comment by and...@andrews-corner.org on 8 Dec 2012 at 1:04

GoogleCodeExporter commented 9 years ago
I have been running this patch for a while and it looks to me like an excellent 
beginning for opus support with abcde. I have added some extra documentation to 
the original patch and I would like to commit it soon. Can a few people test 
and retest the patch before I do so?

Original comment by and...@andrews-corner.org on 10 Dec 2012 at 1:21

Attachments:

GoogleCodeExporter commented 9 years ago
Looks like we can have a few more tags added in, all looking good on my system 
:).

Original comment by and...@andrews-corner.org on 10 Dec 2012 at 4:34

Attachments:

GoogleCodeExporter commented 9 years ago
I've tested the patch extensively - ripped around 50 CDs with it. Also just 
tested v3 and additional tags work good (I intended to test that --comment 
option, but got sidetracked working on Opus decode plugin for MOC).

BTW. You could mention me as "Tomasz Golinski" in changelog instead of this 
partial gmail address ;)

Original comment by tomasz.g...@gmail.com on 10 Dec 2012 at 12:15

GoogleCodeExporter commented 9 years ago
I have changed the name in my version of the patch. I too have tested the patch 
extensively, although I cannot claim to have used 50 cds :) and all is well. I 
hope you don't mind that I have added some documentation to your patch? Feel 
free to suggest any changes, point out any mistakes that I have made.

In the sample abcde.conf file I have suggested something simple for settings:

# OPUS
# For the encoder options look at: opusenc -h.
#OPUSENCOPTS='--bitrate 192'

Do you have any thoughts on something simple as suggested syntax?

If all is well I hope to commit this weekend, this is when I will get some time 
away from work to make sure everything is just right, I am a little obsessive 
with fine details :).

Original comment by and...@andrews-corner.org on 11 Dec 2012 at 6:35

GoogleCodeExporter commented 9 years ago
Sure I don't mind. I'm sorry I was to lazy to think about adding the 
documentation myself. 

Only comment I have is that your suggested bitrate is really high for Opus. It 
defaults to 96 for stereo data, so twice that could probably be considered 
"extreme" quality. But since it is only a suggested option in abcde.conf, I 
think it is not that important.

Original comment by tomasz.g...@gmail.com on 11 Dec 2012 at 11:20

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r374.

Original comment by and...@andrews-corner.org on 14 Dec 2012 at 12:06

GoogleCodeExporter commented 9 years ago
Thanks for opus encoding tomasz :)

Original comment by and...@andrews-corner.org on 14 Dec 2012 at 12:08

GoogleCodeExporter commented 9 years ago
Just a minor remark: in tagging code "track" tag should be "tracknumber" just 
like in vorbis case.

Original comment by tomasz.g...@gmail.com on 28 Mar 2014 at 7:39

GoogleCodeExporter commented 9 years ago
Hello,

In specification of ogg format, the field names "track" and "year" doesn't 
exist,  we should use respectively tracknumber & date
Please find attached to this comment a patch

References :
http://tools.ietf.org/html/draft-terriberry-oggopus-01#ref-vorbis-comment
http://www.xiph.org/vorbis/doc/v-comment.html

Thanks for your great tool!
Best regards

Original comment by 4lex...@gmail.com on 28 Apr 2014 at 11:22

Attachments: