rexstout / abcde

Automatically exported from code.google.com/p/abcde
GNU General Public License v2.0
0 stars 0 forks source link

Add support for cd ripper pird #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The attached patch adds support for the cd ripper pird to abcde.
I successfully use abcde togeher with pird for some month now. No problems so 
far.

For pird see:
https://github.com/karheinz/pird
http://www.gnu.org/software/libcdio/projects.html

Original issue reported on code.google.com by kars...@sidenotes.de on 21 Apr 2013 at 6:11

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks Karsten. I shall set about getting  D Compiler + pird and check it out.

Original comment by and...@andrews-corner.org on 21 Apr 2013 at 10:41

GoogleCodeExporter commented 9 years ago
I have pird running now. Runs cleanly as a stand alone but I have an error when 
running from abcde:

**************
Grabbing track 01: Atom heart mother...
INFO: Start job: Read track 1.
INFO: Try to read 106825 sectors starting at sector 0.
INFO: Data is written to track_01.wav.
INFO: |========================================================================|
INFO: Read and wrote 106825 sectors.
[ERROR] abcde: The following commands failed to run:
readtrack-01: pird  returned code 73
Finished. Not cleaning /home/andrew/abcde.3e0c3605.
***************

and I notice that pird was writing track_01.wav both to 
/home/andrew/abcde.3e0c3605 and to /home/andrew/track_01.wav. Are you running 
pird from ~/.abcde.conf and with what settings?

Original comment by and...@andrews-corner.org on 22 Apr 2013 at 12:15

GoogleCodeExporter commented 9 years ago
I always run abcde with USEPIPES=y, so i didn't came across this error :(
Attached patch adds support for pird and fixes the stated error.

Original comment by kars...@sidenotes.de on 22 Apr 2013 at 6:32

GoogleCodeExporter commented 9 years ago
Here is the patch:

Original comment by kars...@sidenotes.de on 22 Apr 2013 at 6:33

Attachments:

GoogleCodeExporter commented 9 years ago
Now working as expected, thanks for your work with this. I have not used 
USEPIPES as I have on many occasions encoded to multiple formats so it was a 
good catch :). I will leave things as they are until the weekend so others can 
have a look at the new cdreader and then commit.

If you have the time and motivation could you also have a look at where pird 
fits into the man pages and also the sample abcde.conf document? If not I shall 
fix it up before I commit on the weekend.

Thanks again for pird + abcde!

Original comment by and...@andrews-corner.org on 22 Apr 2013 at 10:24

GoogleCodeExporter commented 9 years ago
I added some words/lines to man page and sample abcde.conf file. I also added 
the capability to set drive speed used by pird via CDSPEEDVALUE.

Original comment by kars...@sidenotes.de on 24 Apr 2013 at 7:05

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r381.

Original comment by and...@andrews-corner.org on 26 Apr 2013 at 11:34

GoogleCodeExporter commented 9 years ago
Thanks very much for this karsten!

Original comment by and...@andrews-corner.org on 26 Apr 2013 at 11:35