search

rexyai / RestRserve

R web API framework for building high-performance microservices and app backends
https://restrserve.org
271 stars 31 forks source link

Trying to fix #160 #162

Closed artemklevtsov closed 3 years ago

dselivanov commented 3 years ago

inst/tinytest/test-cl-router.R:133:1: style: Trailing blank lines are superfluous.

​
^
dselivanov commented 3 years ago

CI seems fails because of my previous changes.

dselivanov commented 3 years ago

inst/tinytest/test-cl-router.R:132:1: style: Trailing blank lines are superfluous.

​
^
artemklevtsov commented 3 years ago

CI seems fails because of my previous changes.

Could you tell me more about this?

dselivanov commented 3 years ago

Could you tell me more about this?

see here https://github.com/rexyai/RestRserve/commit/f8e8f7def89a8e1a264735725a5184da7fc8d851

Also as per #160 we need to support filename with and without quotes. And in future would be nice to support filename* (as per rfc6266)