Closed DavZim closed 2 years ago
Once this PR merged I plan to release 1.0.0 on the CRAN
Using the new commits, all open issues should be addressed.
Before the CRAN release. I planned on making a PR regarding Etags (see also https://stackoverflow.com/questions/71527627/r-restrserve-add-etag-to-static-path), do you have a place where we can discuss this? It would be great if that feature would make it to the next CRAN release as well.
Before the CRAN release. I planned on making a PR regarding Etags (see also https://stackoverflow.com/questions/71527627/r-restrserve-add-etag-to-static-path), do you have a place where we can discuss this? It would be great if that feature would make it to the next CRAN release as well.
Being able to utilize Etags would be great.
With PR #182, this is now independent from any discussion around ETags.
The requested changes have been made and this PR should be ready to be merged (at least from my perspective)
Thanks! Sorry for delay, just too many things on my plate this week. Will merge soon.
On Thu, 24 Mar 2022, 12:08 DavZim, @.***> wrote:
With PR #182 https://github.com/rexyai/RestRserve/pull/182, this is now independent from any discussion around ETags.
The requested changes have been made and this PR should be ready to be merged (at least from my perspective)
— Reply to this email directly, view it on GitHub https://github.com/rexyai/RestRserve/pull/181#issuecomment-1077346789, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHC5XJRBX4OHPIUOYFEH5LVBQPHTANCNFSM5RBUUBAA . You are receiving this because your review was requested.Message ID: @.***>
Merging #181 (a2d67a1) into dev (64599bc) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head a2d67a1 differs from pull request most recent head da1d045. Consider uploading reports for the commit da1d045 to get more accurate results
@@ Coverage Diff @@
## dev #181 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 27 27
Lines 1305 1305
=======================================
Hits 1240 1240
Misses 65 65
Impacted Files | Coverage Δ | |
---|---|---|
R/Application.R | 96.71% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 64599bc...da1d045. Read the comment docs.
Adds tests for #180