rexyai / RestRserve

R web API framework for building high-performance microservices and app backends
https://restrserve.org
276 stars 32 forks source link

content handlers #67

Closed dselivanov closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #67 into dev will increase coverage by 8.67%. The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
+ Coverage   83.88%   92.55%   +8.67%     
==========================================
  Files          22       26       +4     
  Lines        1123     1169      +46     
==========================================
+ Hits          942     1082     +140     
+ Misses        181       87      -94
Impacted Files Coverage Δ
R/openapi.R 100% <ø> (ø) :arrow_up:
R/utils.R 100% <ø> (+18.18%) :arrow_up:
R/RestRserveAuthMiddleware.R 100% <100%> (+29.41%) :arrow_up:
R/json.R 100% <100%> (ø) :arrow_up:
R/RestRserveMiddleware.R 100% <100%> (ø) :arrow_up:
R/logging.R 100% <100%> (+52.94%) :arrow_up:
R/AuthBackendBearer.R 100% <100%> (ø)
R/RestRserveResponse.R 97.54% <100%> (+25.91%) :arrow_up:
R/RestRserveRouter.R 97.53% <100%> (+0.03%) :arrow_up:
R/AuthBackend.R 100% <100%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3140ad...286397b. Read the comment docs.

artemklevtsov commented 5 years ago

Need test for the ContentHandlers class also.

lintr-bot commented 5 years ago

inst/tinytest/test-app-content-handlers.R:50:1: style: lines should not be more than 120 characters.

​expect_equal(rs[[1]], "lexical error: invalid char in json text.\n                              {\"bad\" : json}\n                     (right here) ------^\n")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

inst/tinytest/test-cl-error.R:55:4: style: Place a space before left parenthesis, except in a function call.

​for(err_method in error_methods) {
   ^