rexyyong / pe

0 stars 0 forks source link

Recipe cannot contain |, if not all data is lose for some reason, where loading and saving fails #12

Open rexyyong opened 5 months ago

rexyyong commented 5 months ago

note

Note that this was done without me editing the txt file

Input typed in

  1. add
  2. egg | salt | ham | cheese
  3. mix the stuff. Serve

Screenshots

Before exit images image.png

entering app after exiting

image.png

soc-se-bot commented 5 months ago

Team's Response

As stated in the example ingredients should be separated by commas instead of '|'. However, we accept it because it is a valid issue, we should state more clearly the instruction in the UG.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Command add [GROCERY]: entering add (text) | (text) renders list invalid after exiting and re-entering program

Screenshot 2024-04-19 at 5.05.03 PM.png

Screenshot 2024-04-19 at 5.05.32 PM.png

Input Order: 1) add oil | terrorism | america 2) exit 3) list

Output after last command:

list There's no groceries!

Adding a grocery in the format (text) | (text) makes the list show nothing when the program is relaunched.


[original: nus-cs2113-AY2324S2/pe-interim#1664] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Normal grocery does not have a special character, especially multiple of them together shown in one single grocery. However, this is a valid bug as we should have state in the UG to warn user to not input special characters in grocery names.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe that the severity of this bug should be medium, not low. The reason why I believe that this bug is not of low severity is because this bug causes more than a **minor** inconvenience to users. Let us imagine the following 2 cases 1. User types in | accidentally in recipe 2. User types in | intentionally to split the recipe ingredients In both cases, the data of recipe list will be completely lost. Imagine if the user typed in 100 entries of recipes before that, and that next instance because of this accidental case of typing in |, he or she loses all his data, the scenario would disastrous. Hence, this I believe that this is more than a minor inconvenience, and thus it should be a severity thats higher than low. The screenshot below shows the definitions of severity levels. ![image.png](https://raw.githubusercontent.com/rexyyong/pe/main/files/49d02d04-f380-4882-bb36-d1bbc3a40d72.png) Furthermore, the UG does not say not to include special characters. It only says dont put slash symbol for grocery as shown below ![image.png](https://raw.githubusercontent.com/rexyyong/pe/main/files/3fbb3995-4fb5-4e95-9dc0-3bcdce6869c6.png) After looking at Add command for UG. It does not mention anything about special characters too. The UG description for `add` is rather vague as well. Therefore, I believe that the severity should be higher than low, because 1. Users may key in | in their commands 2. The UG does not sufficiently warn against using | The screenshot below contains the add part of recipe of the UG. ![image.png](https://raw.githubusercontent.com/rexyyong/pe/main/files/aa8f47eb-3244-481a-9ed7-b53cfba4666f.png)