rey444 / shreya

Apache License 2.0
0 stars 2 forks source link

Week 18 Review Ticket - Shreya Sapkal #11

Open rey444 opened 1 year ago

rey444 commented 1 year ago
  1. CPT Scoring Assignment #2
  2. Individual Notes & Hacks for Model and Object-Oriented Programming
  3. Individual Notes for View and Frontend Coding
  4. Team work from the week
jm1021 commented 1 year ago

CPT grading seems a little difficult with columns being free form on why they got point. 0/1 grading is you have it or not. Your summary is excellent, the objective of these reviews is personalization. You show that in your reflection/summary.

On your personal OOP implementation it looks like there is a bug, name is displaying car type. It is important to check things and try to fix them before delivery.

The last two links, one does not take me anywhere, the other takes me to a black screen image. It is hard to make an assessment on either.

akshat122805 commented 1 year ago

1/1 - Summary is great but I am a bit confused on your criteria, there is a lot of personalization 1/1 - Your backend is great and I see tester code, but you also need to explain how your code works like self, constructor, etc. 1/1 - Your frontend is good and I see good progress for the website - You understand the criteria and evaluations of CPT. Also, we want to see how understanding scoring of these examples will help you exceed CPT requirements.

Total: 3/3

TheGerbil21 commented 1 year ago

OOP Hacks and Code: 1/1 CRUD Frontend: 1/1 CPT Grading: 1/1

Comments: Shreya, I really enjoyed all parts of your code. I'm assuming your group is doing a program on searching brands of cars, and I think you have developed both your OOP backend code with individualized class, attributes, and features. I do think the individual OOP code could be developed much further. I also liked how you updated your page with login/signup systems, with detail on the visual design. CRUD is definitely established. CPT scoring does really need checkboxes or another way to show that the requirements of CB are being met. Even if one or two of the final requirements weren't met here, you have proven that work is being done.