reyesoft / ngx-jsonapi

JSON API client library for Angular 5+ 👌 :: Production Ready 🚀
https://ngx-jsonapi.reyesoft.com/
MIT License
101 stars 52 forks source link

Cached request observables are not completing #133

Closed xaun closed 6 years ago

xaun commented 6 years ago
.all().subscribe(
  () => console.log('onNext'),
  null,
  () => console.log('completed')
);
/*
 output: 

 onNext
 completed
*/

with ttl (on second load, once the cachestore is set):

.all({ ttl: 300 }).subscribe(
  () => console.log('onNext'),
  null,
  () => console.log('completed')
);
/*
 output: 

 onNext
*/
pablorsk commented 6 years ago

wich version are you ussing? I think this problem was solved: https://github.com/reyesoft/ngx-jsonapi/blob/v2.0/src/service.ts#L205

xaun commented 6 years ago

@pablorsk 1.1.1, so ok, I guess you can close it then