reyesoft / ngx-jsonapi

JSON API client library for Angular 5+ 👌 :: Production Ready 🚀
https://ngx-jsonapi.reyesoft.com/
MIT License
101 stars 52 forks source link

Add support for rxjs 6 #87

Closed MikaStark closed 6 years ago

MikaStark commented 6 years ago

Now we are on Angular 6 and rxjs 6. It's a shame to use rxjs-compat.

maxi7587 commented 6 years ago

Hi @MikaStark! If we use the latest version of rxjs without rxjs-compat, the library breaks compatibility with Angular 5, and some users are still using this version of Angular. I'm sure this will change in the near future, but for now we should continue using ngrx-compat (at least until everybody moved to Angular 6).

MikaStark commented 6 years ago

You can create a branch for it

pablorsk commented 6 years ago

Hi @MikaStark, can you fork and PR to new branch?

https://github.com/reyesoft/ngx-jsonapi/tree/rxjs6

Thanks!