search

reymond-group / map4

The MinHashed Atom Pair fingerprint of radius 2
MIT License
107 stars 32 forks source link

Dependency on Python 3.6 [suggestion] #15

Open mohammad-saber opened 3 years ago

mohammad-saber commented 3 years ago

Hi,

I remember when I installed MAP, I should use Python 3.6. Is there any plan to remove this dependency so we can use newer python versions?

This dependency is because of importing tmap library (I think). If tmap is replaced with the MinHash formula (explained in the paper), I think there is no need to import tmap, and dependency will be removed. It is only a suggestion.

UnixJunkie commented 6 months ago

The documentation doesn't mention this library requires Python-3.6 . Or, did I miss something?

LucaCappelletti94 commented 1 month ago

@UnixJunkie it does here: https://github.com/reymond-group/map4/blob/ea88e77605f7dc9517b3cb769a7c535413b81823/environment.yml#L7