search

reymond-group / map4

The MinHashed Atom Pair fingerprint of radius 2
MIT License
107 stars 32 forks source link

AttributeError: module 'tmap' has no attribute 'Minhash' #24

Open UnixJunkie opened 6 months ago

UnixJunkie commented 6 months ago 
Traceback (most recent call last):
  File "/home/berenger/src/map4/map4/map4.py", line 182, in <module>
    main()
  File "/home/berenger/src/map4/map4/map4.py", line 137, in main
    calculator = MAP4Calculator(args.dimensions, args.radius, args.is_counted, args.is_folded)
  File "/home/berenger/src/map4/map4/map4.py", line 33, in __init__
    self.encoder = tm.Minhash(dimensions)
AttributeError: module 'tmap' has no attribute 'Minhash'
UnixJunkie commented 6 months ago

Which version of tmap are we supposed to use?

UnixJunkie commented 6 months ago

Can't this command:

pip install git+https://github.com/reymond-group/map4@v1.0

be made to pull all the required dependencies at an adequate version?

UnixJunkie commented 6 months ago

if MinHash is so important to map4, it should probably be included and not be provided by an external dependency

LucaCappelletti94 commented 1 month ago

Did you end up finding how to get MinHash out of tmap?