reynico / raspberry-noaa

Fully automated ISS SSTV, NOAA and Meteor satellite image downloader using Raspberry PI
https://github.com/reynico/raspberry-noaa
GNU General Public License v3.0
179 stars 56 forks source link

[Error] - hardcoded paths using 'pi' user #144

Open danielrbjo opened 3 years ago

danielrbjo commented 3 years ago

Describe the bug The default installation script presumes the user 'pi' is universal and uses it in some, not all, path references. For users, like me, that always disable the 'pi' user for security purposes, this has the effect of preventing both complete installation and successful operation.

Recommendation make all paths referential to current user or user-definable

Server information (please complete the following information):

Additional context I didn't note exactly which files needed to be updated to referential paths, but it wasn't too many. Is now working like a champ! Update: Grep for '/pi' in files returns - filename/line number/search term:

INSTALL.md:180:/pi/ INSTALL.md:185:/pi/ install.sh:195:/pi/ ISS.md:29:/pi/ receive_meteor.sh:85:/pi/ receive_meteor.sh:86:/pi/ receive_meteor.sh:91:/pi/ receive.sh:56:/pi/ receive.sh:58:/pi/ receive.sh:61:/pi/ receive.sh:72:/pi/ schedule_iss.sh:34:/pi/ schedule_meteor.sh:34:/pi/ schedule_sat.sh:40:/pi/ templates/noaa.conf:1:/pi/ templates/webpanel/Model/Conn.php:5:/pi/ WORKING.md:42:/pi/