search

reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

Added ability to mark all snapshots as reviewed in review menu dropdown #10

Open kgwebsites opened 6 years ago

reywood commented 6 years ago

I'm afraid I'm not familiar with snapshots in the context of pull requests. Are they images?

kgwebsites commented 6 years ago

Not quite, they are files that end in ".snapshot" that are renderings of the code of another file at the time being. For example you may have a file called component.js. You run your snapshot generator and generate the component.js.snapshot file.

They are used for testing software where you want to know when the snapshot file changes, you know that whatever new code you submitted in the PR affected that snapshot. For that same example, if you made a file called component2.js and ran your snapshot generator, and component.js.snapshot changed, then you know your new component2.js affected the rendering of component1.js.

In the context of pull requests, they rarely are actually reviewed, only the the names of the files are relative, and when you notice a snapshot that shouldn't be there, then you can view the snapshot and see the differences. But generally, at least when developing using jest for testing, snapshots can take up more than 40% of the PR and it can be quite annoying to have to select each one as complete.

reywood commented 6 years ago

Ah, I see. Just spitballing here, but maybe it would be a cool feature to have the extension detect all file extensions present in the pull request and offer menu options to mark/unmark all files with each extension. I just see this sort of thing getting out of hand if options like this are always present regardless of whether those types of files are present. Thoughts?

kgwebsites commented 6 years ago

That’s a great idea. I’ll see if I can implement it in my PR

On May 21, 2018, at 1:48 PM, Sean Dwyer notifications@github.com wrote:

Ah, I see. Just spitballing here, but maybe it would be a cool feature to have the extension detect all file extensions present in the pull request and offer menu options to mark/unmark all files with each extension. I just see this sort of thing getting out of hand if options like this are always present regardless of whether those types of files are present. Thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.