search

reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

"Done Reviewing" the entire pull request #17

Open jonathantodd opened 5 years ago

jonathantodd commented 5 years ago

When viewing your list of pull requests, would it be possible to show which ones you are done reviewing? Sometimes we leave comments that need some action taken and we don't want to decline or approve the review, but we also want to see which pull requests in our list have been reviewed and which haven't.

This could be done by checking if all the files are reviewed, or by adding a separate "Done Reviewing" button at the pull request level.

reywood commented 5 years ago

Not sure this is possible. Currently, the extension creates a hash for each file of all added, changed, and removed lines. When a file is marked as reviewed, the hash is saved. If a new commit is made in a pull request, the hash won't match for any files that have been updated, and the extension then marks the file as unreviewed. Since the necessary info is only available on the actual pull request page, this wouldn't be possible from the list page.

I'm open to any ideas on how to make this possible using info available from the list page.

jonathantodd commented 5 years ago

Ahh, I see what you mean.

Well, not sure if it'll work, but here's one idea: it looks like the list page has the most recent commit ID stored in some of the metadata. When you're on the pull request page and you've finished reviewing all the files, could the extension store which commit ID it has finished reviewing up to? And then could the list page check that against to see if it's reviewed?