reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

Improvement - mark comments as completed #2

Open frejfrej opened 7 years ago

frejfrej commented 7 years ago

When reviewing, you can have some conversations that remain in the PR because the related update is not on the specific line you commented on, or it is on the file itself.

It would be nice to have the ability to mark a conversation as done / completed.

This would hide the comment and add a small (X) label (X being the number of hidden comments in the hidden conversation). Clicking the (X) would restore / unhide the conversation.

frejfrej commented 7 years ago

In fact, having all comments marked "completed" could be considered a requirement before clicking "Approve"...

reywood commented 7 years ago

Good idea! I usually use tasks to denote when a comment has been addressed, but I can definitely see how collapsing comments would be useful. Can't promise when, but I'll look into this when I get a chance.