search

reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

Make PR Review Helper work with the new PR review experience. #37

Closed epicserve closed 4 years ago

epicserve commented 4 years ago

This browser extension stopped working when I switched to the new PR review experience.

reywood commented 4 years ago

The new PR interface has a built in way to collapse files via a little down arrow chevron on the left side of each file's header. I'm not sure it's worth it to try to port this extension to the new interface. Thoughts?

epicserve commented 4 years ago

@reywood, right but it doesn't save where you were at ... so if you close the tab or refresh it starts over. I do understand your thought that it might not be worth it. It's also on the list of things they want to add natively, but who knows how long that will take. They still don't have syntax highlighting! 😜

I just thought if it wasn't that hard to do that it would be a nice stop-gap solution.

reywood commented 4 years ago

Hmm, it remembers the state for me. If I collapse a few files and reload, those files are still collapsed. Maybe that's a feature they're rolling out slowly?

epicserve commented 4 years ago

Could be ... strange it seems to be remembering now.

BTW, for anyone that's interested here is their issue for adding it natively.

https://jira.atlassian.com/browse/BCLOUD-19679