search

reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

Is possible to add this features to an bitbucket server? #38

Open alfreddagenais opened 4 years ago

alfreddagenais commented 4 years ago

I try to get this extension working into my bit bucket server. But the content_scripts match is for only bitbucket.org servers. Have you an Idea if it is possible to add this into a custom bit bucket server? Thanks

reywood commented 4 years ago

What does the URL look like when you're reviewing a PR on your BitBucket server?

Lyova5 commented 4 years ago

I had the same problem with my private stash server, and i solved it by pack/upack extension in chrome, fixed url filter in manifest.json.

alfreddagenais commented 4 years ago

@reywood the URL it's looking like this : https://domain.com/git/projects/ZZZ/repos/XXX/pull-requests/1234

To I try to put this matches URL in the manifest.json of the Google Chrome extension : https://*/git/projects/*/repos/*/pull-requests/*

But it's not working.

After, I try to check the extension by myself first. The big issue for me is bitbucket.org and private bit bucket server it's completely different interfaces. We can't add the same CSS IDs and Classes from your plugin.

For my point of view, we need to build a second extension or wrap into your extension a second way to allow multiple interfaces be filled.

What do you think about?

reywood commented 4 years ago

I'm all for supporting private installs. Curious that it worked for @Lyova5 but not you (different versions?). Maybe they could share the URL filter they used to make it work.

alfreddagenais commented 4 years ago

Thanks @reywood The server I have is Atlassian Bitbucket v7.1.1