search

reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

Improve usability of very large pull requests. #7

Closed timzap closed 6 years ago

timzap commented 6 years ago

I've addressed issues #5 and #6 by adding click listeners to the links that reload unloaded files, and once the markup is loaded the fileDiff button is added.

I've also removed the collapse animation because there's a much bigger performance boost when markup is display: none instead of max-height: 0. I didn't remove any of the previous styling though, so now that styling is sitting there unused.

Also, I didn't run any of the tests because I wasn't able to make nvm work. But I didn't modify the fileDiff or hash files anyway.

reywood commented 6 years ago

Thanks! Amazing how much this improves scrolling.

reywood commented 6 years ago

P.S. sorry it took so long to get to this