reywood / bitbucket-pr-review

Chrome extension that allows you to flag individual files in a pull request as reviewed
GNU Lesser General Public License v3.0
19 stars 14 forks source link

JS error when marking files are revirwed #9

Closed chai-deshpande closed 6 years ago

chai-deshpande commented 6 years ago

image

Please see the call stack of the exception while clicking the "Done Reviewing" button.

VictorQRS commented 6 years ago

This is also happening to me. Is there any progress regarding this issue?

timzap commented 6 years ago

The error occurs when the path to a file (including the filename) has a space in it.

timbeadle commented 6 years ago

@timzap That makes #13 a duplicate of this issue, then.

reywood commented 6 years ago

Thanks to @timzap for the PR. Finally got this merged and put a new version up.