reyzor1991 / foundry-vtt-pf2e-action-support

Apache License 2.0
0 stars 4 forks source link

double slice should consider critical hits in determining which attack has precision damage applied #18

Closed surged20 closed 1 year ago

surged20 commented 1 year ago

createDataDamageOnlyOnePrecision looks at the magnitude of a critical hit without considering 2x damage when determining with attack to apply precision damage to https://github.com/reyzor1991/foundry-vtt-pf2e-action-support/blob/4e72050fd6be1e455f248c08b62bb2665e1f2443/src/main.js#L855

Since the player is permitted to add the precision damage to the attack of their choice, precision damage should be applied to the critical hit in the event that one attack crits and the other is a normal hit. Here is an example of precision damage incorrectly applied to the regular hit.

image

reyzor1991 commented 1 year ago

Fixed in 0.2.26