reyzor1991 / foundry-vtt-pf2e-action-support

Apache License 2.0
0 stars 4 forks source link

flurry of blows persistent dmg doubled #42

Open dharkus5000 opened 4 months ago

dharkus5000 commented 4 months ago

image as you can see from this img, if both the strikes hit, and they have persistent dmg, then the persistent dmg is combined - this is incorrect and currently requires removing the persistent and redoing it every time so that double persistent isn't done, it also does the same on a crit, in this example if 1 crits, it'd be 21d6 + 1d6 persistent, should just be 21d6

reyzor1991 commented 4 months ago

Is there specific rule? Text from action If both hit the same creature, combine their damage for the purpose of resistances and weaknesses.

dharkus5000 commented 4 months ago

just the rule that persistent isn't affected by weakness/resistance, so it makes no sense to apply that rule to that part of the dmg, persistent is a condition, treated separately to dmg, the only creatures that wouldn't get that vitality persistent in the example above, even if the creature had 100 vitality resistance, would be a living creature or a construct, cause they're immune to vitality, every other creature that doesn't meet those 2 types gets it, regardless of everything else, they'd not take the dmg when the persistent happens if they've got say 20 vitality resistance, but they've still got the condition. if you do get 2 instances of vitality persistent, say from both attacks hitting, you just get the highest dmg one, say if 1 att is a crit and 1 is a hit, you'd get 2d6 persistent - i can def quote rules for that last bit on not stacking, the rest is just how persistent is always treated in the rules

iamthetot commented 4 months ago

Is there specific rule? Text from action If both hit the same creature, combine their damage for the purpose of resistances and weaknesses.

Persistent Damage is not damage, it is a condition. When a Strike "deals" Persistent Damage, it is actually applying a condition. Conditions should not stack like this. If the Strike that was being used to Flurry of Blows applied, for example, Frightened 1 on a hit, you would not have inflicted Frighted 2 by having both Strikes hit.

To reiterate, the system should not combine them because they are not damage, they are conditions. For example, on the official SRD, persistent damage is listed in the Conditions Index. It is also listed in the Conditions Appendix in Player Core starting on page 443.

Furthermore, here's what the specific rules say about Persistent Damage regarding weaknesses and resistances (emphasis mine):

Immunities, resistances, and weaknesses all apply to persistent damage. If an effect deals initial damage in addition to persistent damage, apply immunities, resistances, and weaknesses separately to the initial damage and to the persistent damage. Usually, if an effect negates the initial damage, it also negates the persistent damage, such as with a slashing weapon that also deals persistent bleed damage because it cut you. The GM might rule otherwise in some situations.

This is because the damage is not suffered immediately but rather at the end of the sufferer's turn.