reyzor1991 / foundry-vtt-pf2e-reaction

Module for the foundry vtt pf2e system
Apache License 2.0
5 stars 4 forks source link

Improve looks of Recall Knowledge buttons or make labels clickable instead. #20

Closed apoapostolov closed 11 months ago

apoapostolov commented 11 months ago

Recall Knowledge buttons have a very crude CSS that causes significant vertical bloat that pushes attacks and abilities very low and out of screen (for smaller screens). It would be much better if the buttons were much smaller, or instead of buttons of so many Lores that may never exist in the game at all, the labels in the box (much smaller and default sized) were clickable to trigger the behavior.

image

reyzor1991 commented 11 months ago

@apoapostolov New view of Recall Knowledge

Screenshot 2023-07-17 at 13 24 15

Also new setting to add specific lore

Screenshot 2023-07-17 at 13 26 37
reyzor1991 commented 11 months ago

@apoapostolov If you have specific lore which you use as easy DC or very easy DC I would like to add it to module

apoapostolov commented 11 months ago

This looks amazing. One question - if the existing labels and the new button labels have the same CSS, can you hide the existing labels that are not clickable and leave the new label-buttons that are clickable? Also, the hyperspecicic lore that is exactly the name of the creature is not something PF2 even suggests, as the most specific suggested types of Lore are based on creature traits and creature families.

reyzor1991 commented 11 months ago

Hide not clickable label – not a problem.

Now lore easy DC – based on creature traits, But can't find any other infos instead of name to create label with very easy DC

apoapostolov commented 11 months ago

That design space is defined but hasn't been developed in the game. You can let it as is, but very easy DC would make sense to be off by default. But even if you do have it on by default, it is easy to remove so no problem for me.

apoapostolov commented 11 months ago

Looks and works great now, thanks!!

reyzor1991 commented 11 months ago

Added in new release - 0.2.19

New settings

recallSettings

New view

exampleKnowledge