v0.3.1 with pf2e 6.0.3 and foundry v12.327 recall knowledge still non-functional

[azrazalea]

Describe the bug The recall knowledge buttons are not added correctly to NPC Sheets, nor are the default ones removed.

To Reproduce

• Create a world with pf2e 6.0.3, foundry v12.327
• Activate pf2e-reaction module
• Configure settings to enable the recall knowledge feature of the module
• Open NPC sheets and see that no recall knowledge buttons are present

Expected behavior The recall knowledge buttons to be added to NPC sheets and, if applicable, the default ones to be removed.

Screenshots

[reyzor1991]

Please check console, maybe some error exists. Because as I see options like hide default and add lore no work

[Peach774]

This seems to be happening with the newest version of the system 6.4.0, and mine worked previously

[reyzor1991]

Settings is on ? Any errors in console?

[Peach774]

Settings is on ? Any errors in console?

Setting is on - no console errors.

[Peach774]

Okay further testing shows this is a problem specifically with pf2e bestiary tracker. I'm gonna see if it can be fixed on their end first.

[Peach774]

Okay further further testing - I think its a weird conflict with how each thing is looking at what. It seems like PF2e Reaction Checker is looking at actors, not the compendium version of an NPC, but bestiary tracker is looking at the compendium. So for example, your recall knowledge edits show up on the actor sheet of a monster, but not the compendium sheet, which probably shouldnt be the case (they should be the same imo), but bestiary tracking is looking at the compendium thing which confuses me.

[reyzor1991]

This module read info of actor. Actor is editable and could have difference with compendium

[WBHarry]

(PF2E Bestiary Tracking dev) Heya,

It's not really an error on either module. I am simply rendering the base actor's sheet, not the sheet of a token's synthetic actor. So the rendering logic of this module isn't performed, as expected.

if (game.user?.isGM && isNPC(sheet.actor) && sheet.token && Settings.recallKnowledge) { // sheet.token = null in this case

[reyzor1991]

sheet.token - null, only if you open actor sheet from compendium

this module works with "real" actor, but I could delete this check and also show same for compendium

[WBHarry]

What I'm doing on my end is that I have the actor's UUID, fetching the actor and then rendering the sheet. 1) I'm fetching an actor from within the world: game.actors.find(actor => actor.uuid === <savedUUID>). 2) Render actor.sheet.render(true). In this situation, sheet.token = null

Removing that check should allow it to work in the bestiary if that's a possibility for you. If you want to specificly avoid actors in compendiums you could use a check on actor.pack and avoid those 🙃