rezalas / riftshadow

Dedicated to the preservation of the game and modernization of a classic mud codebase.
MIT License
18 stars 14 forks source link

Catch 2.11.0 fails to build tests #177

Closed Psypher9 closed 2 years ago

Psypher9 commented 2 years ago

When running make for the full solution, the Catch 2 dependency fails to build resulting in the following errors

.../tests/catch.hpp:10717:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
10717 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;

and

/tests/catch.hpp:10776:45: error: size of array ‘altStackMem’ is not an integral constant-expression
10776 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};

These errors are directly addressed in an April 2021 release of Catch 2, found here. The original issue is here.

Expected Behavior:

sean-gilliam commented 2 years ago

Merged by #178