Closed GioBonvi closed 5 years ago
I did not notice @fklement's PR (or he opened it after I started working on mine) and it lloks like there are some differences between our versions: I'm open to discussion, especially regarding the dusk/dawn/sunrise/sunset translations, which are a bit vague as they are not terms often used in italian.
@rezemika let us know how you want to proceed.
Thank you for your work!
However, as I don't speak italian at all, it would be difficult for me to judge which translation is "the best"...
Concerning the bug when parsing the fields, it's quite weird: I don't have the same result.
>>> print(hoh.OHParser("Mo-Fr 06:00-21:00; Sa,Su 08:00-12:00", locale="en").description())
['From Monday to Friday: 6:00 AM – 9:00 PM.', 'From Saturday to Sunday: 8:00 AM – 12:00 PM.']
Concerning the bug when parsing the fields, it's quite weird: I don't have the same result.
I'll open an issue on the matter then: it might have to do with some kind of "local" default settings
However, as I don't speak italian at all, it would be difficult for me to judge which translation is "the best"...
I can discuss the differences between our versions with @fklement if you prefer: from what I can see they are mainly about preposition usage and order of day/month in the date (e. g. "febbraio 2" vs "2 febbraio"), plus one or two miscellaneous ("on public and school holidays" and "dusk").
I'll open an issue on the matter then: it might have to do with some kind of "local" default settings
Ok, thank you! Maybe related to a "first day of week" parameter or something?
I can discuss the differences between our versions with @fklement if you prefer: from what I can see they are mainly about preposition usage and order of day/month in the date (e. g. "febbraio 2" vs "2 febbraio"), plus one or two miscellaneous ("on public and school holidays" and "dusk").
Indeed, if you're okay with that, I would appreciate cause, as I said, I don't think I'm competent to judge.
Thanks! :)
Ok, thank you! Maybe related to a "first day of week" parameter or something?
Yeah, I strongly suspect so. I've opened the issue here (#20) and will look in the code for anything suspicious as soon as I can.
Indeed, if you're okay with that, I would appreciate cause, as I said, I don't think I'm competent to judge.
I'll wait for a prompt from @fklement on this thread then.
Sorry for answering so late.
Actually i'm currently learning italian.
So @GioBonvi is probably right. As he says dusk/dawn/sunrise/sunset translations are a bit vague in the italian language.
@rezemika you should definitely go for his pull request as he is a native italian speaker.
No problem, it's okay. :)
Thank you for your answer, and good luck for the Hacktoberfest!
As per the title I've added the italian translation.
I've tested it running all the supported field formats and the language looks ok to me:
However, there seems to be some kind of problem with the first day of the week, because the weekdays in those examples are "monday-friday", but get translated to "domenica-giovedì" (which is "sunday-thursday"). I do not think this is a translation problem, because I get the same problem running the basic example a t the beginning of the README:
Let me know if I'm doing anything wrong: if this is a bug I'll open an issue to discuss it.