reznok / GMCAbilitySystem

An Unreal Engine plugin that adds an ability system to the General Movement Component plugin
MIT License
35 stars 16 forks source link

[Dev] Operations Are Occasionally Processed Multiple Times #99

Open reznok opened 1 week ago

reznok commented 1 week ago

When trying to fix a desync between Ack/Process time on processing server auth operations, I introduced a new bug: https://github.com/reznok/GMCAbilitySystem/blob/1bd4eb9c641bc54b91993c77b866e4d7b0bb7ce1/Source/GMCAbilitySystem/Private/Components/GMCAbilityComponent.cpp#L938

Occasionally, operations are processed multiple times. This seems to happen more on Server-Owned Pawns.

A bandaid fix would be to add a new Processed flag to operations to ensure they're only processed once, but I think it's likely there's a cleaner solution.