search

rezoner / playground

Playground.js is a framework for your javascript based games. It gives you out-of-box access to essentials like mouse, keyboard, sound and well designed architecture that you can expand to your needs.
MIT License
469 stars 49 forks source link

PLAYGROUND.Events.off #19

Closed TNick closed 9 years ago

TNick commented 9 years ago

Should't this line 

      if (this.listeners[event][i]._remove) {
        this.listeners[event].splice(i--, 1);
        len--;
      }

be more like 

      if (this.listeners[event][i].callback === callback) {
        this.listeners[event].splice(i--, 1);
        len--;
      }

?

rezoner commented 9 years ago

IT TOTALLY SHOULD.

rezoner commented 9 years ago

I will push the fix with next relase. Thank you.